Allow Drive to submit a form when spot-enabled but submitter is null #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good with a test for this. |
I agree. Working on it. |
terracatta
force-pushed
the
jem_fix_turbo_enabled_attributes
branch
from
a519e4f
to
7774fe9
Compare
|
@dhh Ok I have a working test that simulates @willcosgrove's initial situation. Let me know if you need anything else. |
|
Boom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392
When you disable Turbo Drive wholesale with
Turbo.session.drive = falseand spot enable it on a form without a submit button withdata-turbo=trueTurbo Drive still wouldn't fire because it couldn't verify that the submitter (which was null) had a container where turbo was enabled.This pulls in @willcosgrove's recommendation. The summary: it's wise to never assume the DOM placement and logic for a submitter that is null.