Read [data-turbo-action] during Form Submissions
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
form-turbo-action
branch
2 times, most recently
from
c9de532
to
285fbbb
Compare
seanpdoyle
force-pushed
the
form-turbo-action
branch
2 times, most recently
from
4dd165b
to
546f113
Compare
In preparation for `<form method="post">`-driven navigations, this commit removes unnecessary `[method]` attributes, and renames `[id]` attributes to communicate the verb to the test cases.
seanpdoyle
force-pushed
the
form-turbo-action
branch
from
546f113
to
fb95592
Compare
Closes hotwired/turbo-ios#44 Follow-up to hotwired#231 --- This commit follows-up [hotwired#231][], which added `[data-turbo-action]` support for idempotent form submissions to maintain parity with `<a>`-initiated Visits. These changes re-use the existent `Navigator.getActionForFormSubmission` function to determine the value for the `VisitOptions.action` options. [hotwired#231]: hotwired#231
seanpdoyle
force-pushed
the
form-turbo-action
branch
from
fb95592
to
7d11df3
Compare
|
Any idea when this could be reviewed/merged so I'm not pinning to a forked branch? Thanks! 😄 |
|
Pinning to a forked branch is fine. Did a big push to get Turbo 7 out the door. Probably will be a little while until there's another push for Turbo 7.1. |
OK cool, thanks for the update. |
|
Seems like we've already picked up this fix through one of the other PRs. But I'll merge for the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes hotwired/turbo-ios#44
Follow-up to #231
This commit follows-up #231, which added
[data-turbo-action]support for idempotent form submissions to maintain parity with
<a>-initiated Visits.These changes re-use the existent
Navigator.getActionForFormSubmissionfunction to determine the value for the
VisitOptions.actionoptions.