Frames: handle GET form submissions
#449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
form-targets-action-get
branch
from
c31f4cd
to
abb060a
Compare
|
While investigating this issue, I also uncovered some additional Frame-to-Visit quirks. I've opened #448 to address those. |
Closes [446][]. When handling a `<form method="get" action="..." data-turbo-frame="...">` submission targeting a `<turbo-frame>` element, responses that don't redirect do not change the element's `[src]` attribute. Following the changes made in [424][], `<form>` submissions that result in `GET` requests are handled the same as other form submissions in that they fire `turbo:submit-start` and `turbo:submit-end` events. What [424][] did not account for is navigations initiated by `<form method="get">` submissions that _do not_ redirect. In response to those requests, this commit adds two additional criteria for updating the `<turbo-frame src="...">` attribute: * the response's status code is [200 OK][], which is idempotent and does not indicate a server-side state change (for example, like a [201 Created][] with a `Location:` header might) * the response's `Content-Type:` is HTML (not JSON or even Turbo Stream) Under those circumstances, the frame's `[src]` is updated. This commit adds test coverage for this new behavior along with additional coverage to guard against regressions. [446]: hotwired#446 [424]: hotwired#424 [200 OK]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/200 [201 Created]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/201
seanpdoyle
force-pushed
the
form-targets-action-get
branch
from
abb060a
to
7c57501
Compare
While testing the progress bar rendering, navigate the page to the `/__turbo/delayed_response` to sleep for 1 second to give the progress bar a chance to render. Similarly, wait on the `turbo:load` event to ensure that the progress bar is hidden.
seanpdoyle
force-pushed
the
form-targets-action-get
branch
from
7c57501
to
174ebd3
Compare
|
@dhh if this is a good enough fix, I think that it'd be good to include in 7.1.0-rc2. |
|
Thanks @seanpdoyle @dhh! I just tried rc2 and everything is looking great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 446.
When handling a
<form method="get" action="..." data-turbo-frame="...">submission targeting a<turbo-frame>element,responses that don't redirect do not change the element's
[src]attribute.
Following the changes made in 424,
<form>submissions that resultin
GETrequests are handled the same as other form submissions in thatthey fire
turbo:submit-startandturbo:submit-endevents. What424 did not account for is navigations initiated by
<form method="get">submissions that do not redirect.In response to those requests, this commit adds two additional criteria
for updating the
<turbo-frame src="...">attribute:not indicate a server-side state change (for example, like a 201
Created with a
Location:header might)Content-Type:is HTML (not JSON or even Turbo Stream)Under those circumstances, the frame's
[src]is updated.This commit adds test coverage for this new behavior along with
additional coverage to guard against regressions.