Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't scroll to top of page on reload #571

Merged
merged 7 commits into from
May 19, 2022
Merged

Don't scroll to top of page on reload #571

merged 7 commits into from
May 19, 2022

Commits on Apr 18, 2022

  1. Don't scroll on reload 

    Potential solution for hotwired#387
    @srt32
    srt32 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    306e125 View commit details
    Browse the repository at this point in the history

  2. Be more specific with the check

    @srt32
    srt32 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    e556de3 View commit details
    Browse the repository at this point in the history

  3. Put the check back

    @srt32
    srt32 committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    b94abc0 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. Guard the performScroll call directly

    @srt32
    srt32 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    34e9529 View commit details
    Browse the repository at this point in the history

  2. WIP - spec

    @srt32
    srt32 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    2b5a378 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Properly assert in scroll spec 

    Co-authored-by: manuelpuyol@github.com
    @srt32
    srt32 committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    e411397 View commit details
    Browse the repository at this point in the history

  2. Update rendering_tests.ts

    @srt32
    srt32 committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    10cd8a6 View commit details
    Browse the repository at this point in the history