Wait for CSS to be loaded before replacing the Body #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
reviewed
Jun 28, 2022
|
What would the failure state be if those assets fail to load (bad CDN or whatever)? How long would we wait for them to load? Do we need a timeout? |
seanpdoyle
reviewed
Jun 29, 2022
good shout, I've added a timeout as @seanpdoyle suggested |
rik
reviewed
Jun 29, 2022
Co-authored-by: Anthony Ricaud <anthony@ricaud.me>
|
@seanpdoyle @rik what do you think of the changes now? I've implemented your suggestions :) |
|
Do we have adequate test coverage for this? |
added tests in 3171b0a |
|
@dhh this should be ready for some 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #613
As suggested in #613 (comment), we can listen for
loadanderrorevents in stylesheets to make sure they are loaded before continuing a render.Here I'm updating how
PageRendereradds new stylesheets to the document head, adding listeners to those events and waiting them to fire before replacing the body.