Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow isHTML to be overridden #615

Closed
wants to merge 1 commit into from
Closed

Allow isHTML to be overridden #615

wants to merge 1 commit into from

Conversation

bteller
Copy link

@bteller bteller commented Jun 29, 2022

This exposes isHTML as a session variable to allow overriding the function used in the same manner as Turbo.session.drive = false can be used to disable turbo functionality by default and placing it in opt-in mode. To modify the default isHTML check one can simply do the following.

Turbo.session.isHTML = (url) => { return true; }

@bteller
Copy link
Author

bteller commented Jun 29, 2022

I attempted to run the tests locally before submitting this, was able to resolve the chromedriver error by installing the chromedriver cask on my Mac and setting an environment variable for CHROMEVER that pointed at it, and there were a number of failures. It appears that might be an issue on the main branch as well, but do let me know if this PR is worth consideration and I will dig in and attempt to sort out my local environment test issues if not global.

@dhh
Copy link
Member

dhh commented Jul 15, 2022

We're exploring this on #519.

@dhh dhh closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants