Add support for data-turbo-action to link_to #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
approved these changes
Jul 18, 2022
seanpdoyle
reviewed
Jul 18, 2022
ondrej-zadnik
force-pushed
the
support-data-action-for-link-to
branch
from
67c5ac7
to
63546ad
Compare
|
@seanpdoyle @dhh Do you think we could add this to the turbo release 7.2? It would be helpful because now we have to use |
|
Yes. Please do rebase and we'll get it in. |
ondrej-zadnik
force-pushed
the
support-data-action-for-link-to
branch
from
dbfadab
to
9835486
Compare
|
@dhh rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I described in hotwired/turbo-rails#359
link_toignoresdata-turbo-actionin combination withdata-turbo-method.Original error was found in
convertLinkWithMethodClickToFormSubmissionbut it was overwritten by #631. Unfortunately thedata-turbo-actionforlink_tois still missing.I added the
data-turbo-actionsetting toFormLinkInterceptorin the same way asdata-turbo-confirmand added a test for it.