Turbo Streams: Preserve permanent elements #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes hotwired#623 Refactor the `Snapshot` implementation to make the permanent element finding code re-usable outside that module. Then, introduce the `StreamMessageRenderer` class, and re-use that code. The `StreamMessageRenderer` class also implements `BardoDelegate`, and relies on `Bardo.preservingPermanentElements` to manage elements across their `<turbo-stream>` rendering lifespan.
seanpdoyle
force-pushed
the
fix-issue-623
branch
from
bb5fb5b
to
4a86bbe
Compare
```
1) [firefox] › navigation_tests.ts:161:1 › test following a same-origin unannotated link inside a data-turbo=false container
page.click: Target closed
=========================== logs ===========================
waiting for selector "#same-origin-unannotated-link-inside-false-container"
selector resolved to visible <a href="/src/tests/fixtures/one.html" id="same-ori…>Same-origin unannotated link inside data-turbo=fa…</a>
attempting click action
waiting for element to be visible, enabled and stable
element is visible, enabled and stable
scrolling into view if needed
============================================================
160 |
161 | test("test following a same-origin unannotated link inside a data-turbo=false container", async ({ page }) => {
> 162 | page.click("#same-origin-unannotated-link-inside-false-container")
| ^
163 | await nextBody(page)
164 | assert.equal(pathname(page.url()), "/src/tests/fixtures/one.html")
165 | assert.equal(await visitAction(page), "load")
at /home/runner/work/turbo/turbo/src/tests/functional/navigation_tests.ts:162:8
```
When driving tests that navigate `[data-turbo="false"]` anchors, replace
the bespoke `await nextBody(page)` helper with Playwright's built-in and
more predictable [Page.waitForEvent("load")][], since the entire
document will navigate.
[Page.waitForEvent("load")]: https://playwright.dev/docs/api/class-page#page-wait-for-event
seanpdoyle
force-pushed
the
fix-issue-623
branch
from
f40de69
to
32f3d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623
Refactor the
Snapshotimplementation to make the permanent elementfinding code re-usable outside that module.
Then, introduce the
StreamMessageRendererclass, and re-use that code.The
StreamMessageRendererclass also implementsBardoDelegate, andrelies on
Bardo.preservingPermanentElementsto manage elements acrosstheir
<turbo-stream>rendering lifespan.