Preserve input values in cache

[entretechno-jeremiah]

This change will save the values of <input>s, <textarea>s, and <select>s when creating a snapshot so that when you navigate back or forward in history, form fields will not be reset.

This behavior was already present prior to 5dfc79e for <input>s and <textarea>s but not <select>s (see turbolinks/turbolinks#238).

[tleish]

@entretechno-jeremiah

Several questions on this PR:

1. With <input>, does it support all types (text, checkbox, radio, hidden, file, etc)
2. With <input>, does it skip caching input type="password" for security purposes.
3. Does it support both <select> one and <select multiple>?
4. Does it support <input type="reset" value="Reset"> and allow a user to reset the form to original values prior to user input?
5. Can I disable caching of an individual field?

<input... data-turbolinks="false">

<form data-turbolinks="false">
  <input ...>
</form>

[entretechno-jeremiah]

@tleish Very good questions. It looks like they've since reverted to cloneNode(true), which makes it work with <input>s/<textarea>s, so I'll be updating this PR to account for that.

1. In my testing, yes it does.
2. No, but good thought. I'll be pushing out an update that does this.
3. No, good catch. I'll be updating this as well.
4. Yes, and I'll be adding a test to assert this.
5. No, but I feel like this is potentially a broader request than just the values of form fields; I think this could apply to any properties/data of any element. I'd welcome some input from the maintainers on if I should add some such functionality though.

[tleish]

@entretechno-jeremiah — FYI, a while back I created an addon library that addresses the above mentioned items. Embedding it into turbo is a much better. An embedded solution also simplifies the approach since the values do not need to be temporarily written to the dom in a data field for caching purposes.

see: https://github.com/tleish/turbo-bfcache-form

The unit tests in this lib might be helpful to consider various scenarios I ran into while creating the library.

This library accomplished item 5 with

if (element.closest('[data-turbo="false"]')) {
  return false;
}

[dhh]

This was left sitting for a long time. If you're still interested, I'd like to see it rebased, so we can merge.

[tleish]

@entretechno-jeremiah - are you able to rebase this?

[entretechno-jeremiah]

Hi there. Jeremiah doesn't work here anymore. I'm his former manager. Is there something we can do to help?

…

On Thu, Aug 4, 2022 at 12:35 PM tleish ***@***.***> wrote: @entretechno-jeremiah <https://github.com/entretechno-jeremiah> - are you able to rebase this? — Reply to this email directly, view it on GitHub <#70 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQQ4U26BCFKD2RIK6MWXUITVXP5ODANCNFSM4VSJ7XXA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *Erin Rollenhagen* | (515) 318-5350 <5153185350> CEO | Entrepreneurial Technologies Inc. Author | Soul Uprising: It's Never Just Business 2135 NW 108th St, PO Box 71245 | Clive, IA 50325 ***@***.*** | www.entretechno.com *Need help?* Email ***@***.*** -- we're here for you!

[seanpdoyle]

I'm happy to pick this branch up and move it forward.

[seanpdoyle]

I've opened #666 to re-submit this changeset. It's rebased off the latest main, and retains @entretechno-jeremiah authorship.