Reintroduce Visit identifier property
#718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Sep 16, 2022
There was a problem hiding this comment.
Thanks @kevinmcconnell! That also explains why it was unused throughout the @hotwired/turbo codebase...
Would you mind adding a comment for this, so that we don't run into the same issue again?
This property is required by turbo-ios, so removing it causes crashes within that library. E.g. https://github.com/hotwired/turbo-ios/blob/main/Source/WebView/WebViewBridge.swift#L129 This reverts commit d81e24d.
|
@marcoroth yeah, same thing just occurred to me after pushing 👍 Added now. |
seanpdoyle
added a commit
to seanpdoyle/turbo
that referenced
this pull request
Sep 19, 2022
With the reverting of [hotwired#569][] (merged as [hotwired#718][]), the "Visit with network error" test coverage was missed in the diff. Prior to the revert, the test was listening for `turbo:fetch-request-error` events dispatched on the _link_ that was clicked. Since that's no longer the case, this commit changes the test to listen for `turbo:fetch-request-error` that bubble up to the document. [hotwired#569]: hotwired#569 [hotwired#718]: hotwired#718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property is required by turbo-ios, so removing it causes crashes within that library.
E.g. https://github.com/hotwired/turbo-ios/blob/main/Source/WebView/WebViewBridge.swift#L129
This reverts commit d81e24d.