Rename header for preload requests #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfeiffer thanks for explaining the problem in #924 and also creating a fix for it. I think @rik is right in that if the standard defines a value for the header, we should adopt it as it will be more forward looking. |
|
Thanks @afcapel! I've updated this PR with the header name and value matching the standard spec. This is a breaking change and would require version bump. It would be great to have this included in Turbo as the current preload header is stripped by eg. Cloudflare and thus pretty unusable. |
|
Thanks @pfeiffer, we'll bump the version before releasing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames header and value for preloaded requests to
x-purpose: preview. See discussion in #924.