FIX: Turbo stream link setting the src of a turbo frame container #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BakiVernes
force-pushed
the
turbo_stream_history
branch
from
98e61ec
to
598c631
Compare
BakiVernes
changed the title
|
I have rebased this PR after the Typescript changes and would love some feedback. This bug has been a pain in our production app for some time now. |
BakiVernes
force-pushed
the
turbo_stream_history
branch
2 times, most recently
from
ac9d24a
to
179b603
Compare
|
Might need a rerun on this. My tests are green. |
shiftyp
reviewed
Sep 12, 2023
afcapel
requested changes
Sep 13, 2023
BakiVernes
force-pushed
the
turbo_stream_history
branch
from
179b603
to
ff8deaf
Compare
afcapel
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Overview
This PR addresses a specific issue that arises when using a Turbo Stream link within a Turbo Frame in a Rails 7 application. Clicking on such a link currently sets the
srcattribute of the Turbo Frame element. Although Turbo saves this state for browser history navigation, it fails to fetch the content correctly. This is because thesrcattribute is intended to be used for Turbo Stream responses, leading to unexpected behavior.Steps to Reproduce
srcattribute of the Turbo Frame element is set.Visual Reference
Proposed Solution
This PR adds a conditional check for the
data-turbo-streamattribute. If the attribute exists, thesrcattribute of the Turbo Frame element will not be modified, thus preserving the expected behavior.By implementing this check, the PR aims to make the behavior of Turbo Stream links within Turbo Frames more predictable and consistent with user expectations.