Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is sent to locked users #76

Open
fonji opened this issue Apr 20, 2016 · 2 comments
Open

Code is sent to locked users #76

fonji opened this issue Apr 20, 2016 · 2 comments

Comments

@fonji
Copy link

fonji commented Apr 20, 2016

Hello and thank you for this gem!

If a user makes too many login attempts, goes back to the login page and logs in again, send_two_factor_authentication_code is still called, so the user gets a code although he can't enter it.
This can be easily avoided in send_two_factor_authentication_code but I think it shouldn't be called at all.

I created a test case and offer a solution here.
I sadly can't make a PR as I already forked a fork of this repository (...), and that means I can't fork the root repository.

@Houdini
Copy link
Owner

Houdini commented Apr 22, 2016

Hello, thanks, I'll merge it

@rgerard
Copy link

rgerard commented Aug 9, 2018

I also ran into this issue today. It doesn't appear that this was ever merged. Want me to open a PR with @fonji's solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants