Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method chaining rule #147

Closed
mike-burns opened this issue Mar 25, 2014 · 4 comments
Closed

Method chaining rule #147

mike-burns opened this issue Mar 25, 2014 · 4 comments
Labels
bug

Comments

@mike-burns
Copy link
Contributor

The guides say to put the . at the end of the line: thoughtbot/guides@237d16b

But @houndci wanted them at the beginning of the next line: thoughtbot/gitsh#149 (see the comments on the outdated diffs).
@salbertson
Copy link
Member

Thanks @mike-burns.

@mike-burns mike-burns mentioned this issue Mar 26, 2014
Merged
@calleluks calleluks mentioned this issue Mar 27, 2014
Closed
@jferris
Copy link
Contributor

jferris commented Mar 27, 2014

This was changed in thoughtbot/guides#146

(adding a link to the pull here so that it will crosslink from the pull for those with access)

@georgebrock georgebrock mentioned this issue Apr 2, 2014
Merged
This was referenced Apr 4, 2014
Merged
Merged
@gylaz gylaz added the bug label Apr 5, 2014
@salbertson salbertson mentioned this issue Apr 8, 2014
Closed
@salbertson
Copy link
Member

We disabled the rule until we upgrade RuboCop.

@salbertson
Copy link
Member

We've upgraded RuboCop and configured the rule to follow our style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mike-burns @jferris @gylaz @salbertson