Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring file structure #12

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Refactoring file structure #12

merged 4 commits into from
Sep 9, 2020

Conversation

EmperorYP7
Copy link
Member

Solves Issue #11

Description: Created a basic file structure for the frontend part of the project with consideration of flexibility to manipulate this in the future.

Checklist

  • I've followed the Contributing guidelines provided in the repository.
  • I've made the changes which were demanded in the linked issue.
  • I've tested my code on a Chromium based browser.
  • I've tested my code on Mozilla Firefox.
  • My code gave a clean console on debugging. (no warnings/errors)

Testimonial

Overview
image

Clean console
image

Copy link
Member

@ankiiitraj ankiiitraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the standard is using lowercase letters with '-' for jsx classNames.
Correct me if I'm wrong.
Rest LGTM

@EmperorYP7
Copy link
Member Author

the standard is using lowercase letters with '-' for jsx classNames.
Correct me if I'm wrong.
Rest LGTM

I think there are many conventions for that. class-name and ClassName both are used in official documentation of React and other projects.
This page gives more information about this.

@ankiiitraj
Copy link
Member

we're using bootstrap which uses lowercase for classes and for consistency will be using lowercase.
Make the changes are you are good to go

@prskid1000
Copy link
Member

LGTM

@ankiiitraj ankiiitraj merged commit 56a4460 into houseofgeeks:front-end Sep 9, 2020
@EmperorYP7 EmperorYP7 mentioned this pull request Sep 10, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants