-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixture for HelloGo fares and NTFS fares v2 #262
Conversation
e386e91
to
3bf41d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've already discussed about the fixtures, but I'm sharing my feedback here anyway :)
In the input xml files:
- each DistanceMatrix should be associated with a different line (so that, in the output, the same origin-destination tickets specified over different lines are distinguishable)
- the lines referenced in the DistanceMatrix should be defined in the ServiceFrame (after the Network)
- I think that two ScheduledPoints should have different associated ProjectedPoints (even though technically this might be correct).
As for the advanced future test cases that you suggest, if the line for a ticket is not defined, then no ticket (with no associated ticket use) is created.
The NTFS is supposed to be prefixed, in which case the object ids should be considered without the prefix. Otherwise (if no prefix is present), the object ids are considered as is.
3bf41d4
to
23fe6f2
Compare
I've updated a few things:
|
cf4a460
to
1a5927a
Compare
a931f8f
to
6cdc3c1
Compare
This is a first version of a fixture from HelloGo fares to NTFS fares v2. A few edge cases will be added in the future like:
line_id
doesn't exist in NTFScontentValidityCondition
doesn't existTriggerObjectRef{ref}
doesn't exist inServiceFrame/Network