Improve documentation for HelloGo fares conversion to NTFS fares #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
force-pushed
the
improve-hellogo-fares-doc
branch
from
3ea26f9
to
0471bf4
Compare
woshilapin
force-pushed
the
improve-hellogo-fares-doc
branch
from
0471bf4
to
1118183
Compare
datanel
changed the title
papailio
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And one more question we could document too:
In
ServiceFrame/scheduledStopPoints, if twoScheduledStopPoints(different or not) have the sameid, which are we supposed to use? First one? Or we consider the whole thing invalid and dump the corresponding Ticket Use Restriction (and then maybe in chain the corresponding Ticket).Note: I'm asking the question because it is a case that was present in the fixture that Nicolas and Virginia did for the fares v1.
Update I discussed about that question with @papailio and the answer is: the file is considered corrupted so we ignore it.