[feature] Automatically remove empty comments from the model #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datanel
previously approved these changes
Sep 9, 2020
woshilapin
force-pushed
the
clean_comments
branch
from
bdddaf0
to
cca3aa9
Compare
datanel
approved these changes
Sep 9, 2020
ArnaudOggy
approved these changes
Sep 9, 2020
|
I realized I forgot to bump the version of |
woshilapin
force-pushed
the
clean_comments
branch
from
9d6de1f
to
51b6d1a
Compare
woshilapin
force-pushed
the
clean_comments
branch
from
51b6d1a
to
fc2f9be
Compare
pbougue
reviewed
Sep 10, 2020
| @@ -1172,6 +1212,7 @@ impl Model { | |||
| /// ``` | |||
| pub fn new(mut c: Collections) -> Result<Self> { | |||
| c.comment_deduplication(); | |||
| c.clean_comments(); | |||
There was a problem hiding this comment.
As discussed: Current "comment_deduplication" would handle multiple things, but for performances it's probably way better to "clean_comment" inside comment_deduplication (and rename?).
If so, to be future-proof, please keep in mind that the key for comment comparison might change (and contain more than just comment.name in the future) 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Model can be cleaned up of comments without any text.
ref: ND-1003.