-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string assert() calls which breaks PHP 7.2 #145
Conversation
@netniV, It seems that the Travis CI build has been stopped. In the I think it should do I also found that it should run the |
Those are issues with @howardjones's build scripts. You should log them as a separate issue and point them at the travis build from this PR to demonstrate it. I have never even got running with a vagrant system yet. |
@netniV, you're right. But the Travis CI build script should be fixed and this PR can check whether the |
This is @howardjones project and i'm just a contributor as I work on the cacti project this integrates with. I won't personally be touching those as they are part of the repo's structure / design (imho) that @howardjones has settled upon and should be handled by him (unless he really wants me to). This PR was purely for the assert problem. I am sure he will appreciate what you've identified. You could even submit a PR with the changes you recommend. |
@netniV, I know that. And I just notice that issue because the Travis CI build should be worked. Thanks. |
@peter279k Thanks for some insight on the TravisCI script! I actually
enabled both TravisCI and CircleCI at different times, but haven't had the
patience to make the dozens of trial & error commits so that the build
script actually builds :-)
The actual phpunit scripts do work though - I use those offline all the
time. Unfortunately, they partly use image comparisons to work, and the
output of GD is subtly different between different PHP versions.
…On 23 July 2018 at 17:56, Mark Brugnoli-Vinten ***@***.***> wrote:
This is @howardjones <https://github.com/howardjones> project and i'm
just a contributor as I work on the cacti project this integrates with.
I won't personally be touching those as they are part of the repo's
structure / design (imho) that @howardjones
<https://github.com/howardjones> has settled upon and should be handled
by him (unless he really wants me to).
This PR was purely for the assert problem. I am sure he will appreciate
what you've identified.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#145 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3sJZLzs-ijdMEdl-u7doHSBckhbjGbks5uJgAvgaJpZM4U8mFH>
.
|
Travis actually fails on legit test failures now (including highlighting the issue in this PR, for PHP 7.2, which is nice!). The image comparison issue I mentioned means that a bunch of tests still fail though. I'll need to generate references images for each version before that can be fixed. |
This PR corrects issues with the assert() function requiring the passed assertion to be a boolean.
Closes #144