-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript builds broken due to issue in botbuilder-streaming #1894
Comments
A fix for this is scheduled to be released next Monday. |
Small update, the fix is in the |
…or Step Down reading. @todo test until howdyai#1894 is resolved.
…or Step Down reading. TODO: cannot test until howdyai#1894 is resolved.
Could someone provide work around steps for this issue? |
4.7.1 will hit npm any minute which should effectively resolve this. |
I'm getting the following build errors after upgrade botkit and botbuilder-adapter-slack. Do I have the right version? My product is broken now and needs this update. Any help are appreciated. Thanks. package.json Error when "npm run build" 15 _write(chunk: any, encoding: string, callback: (error?: Error | null) => void): void; node_modules/botframework-streaming/lib/webSocket/browserWebSocket.d.ts:17:26 - error TS2304: Cannot find name 'WebSocket'. 17 constructor(socket?: WebSocket); Found 2 errors. npm ls | findstr /is bot |
@yingzhanguipath if you do a completely clean build (get rid of all your old node modules and reinstall), this should clear up since it it should grab the 4.7.1 botbuilder pacakges. However I will also be releasing an update to botkit today that will enforce this. |
I tried completely clean build (deleted node_modules and dist folder, then "npm install") several times. But, I'm still getting the same issue. Please advise. |
Strange. |
@benbrown Any update on 4.7.1? |
It was published yesterday. This issue is resolved. |
@yingzhanguipath the new botkit version is 4.6.2 |
Botkit version 4.6.2
|
Same error code but different issue in fact. |
There is a class definition missing from the botbuilder-streaming library that causes this error when building Botkit:
../../node_modules/botframework-streaming/lib/webSocket/browserWebSocket.d.ts(17,26): error TS2304: Cannot find name 'WebSocket'.
This currently blocks Botkit from building.
The text was updated successfully, but these errors were encountered: