Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handleTurn/spawn to accept optional alternate adapter #1920

Closed
benbrown opened this issue Mar 3, 2020 · 0 comments
Closed

Update handleTurn/spawn to accept optional alternate adapter #1920

benbrown opened this issue Mar 3, 2020 · 0 comments
Assignees
@benbrown
Milestone
4.6.+

Comments

@benbrown
Copy link
Contributor

benbrown commented Mar 3, 2020 •
edited

As it is, you can bind multiple adapters to the same Botkit controller. See this example.

However, when the bot worker is spawned, it will always use the "default" controller.adapter that is passed in or created when new Botkit() is called.

We should introduce an optional parameter to the handleTurn call which accepts an adapter that will be used to spawn bots. This is the problematic code
@benbrown benbrown self-assigned this Mar 3, 2020
@benbrown benbrown added this to the 4.6.+ milestone Mar 3, 2020
@benbrown benbrown mentioned this issue Mar 11, 2020
Merged
@sfny sfny mentioned this issue Mar 18, 2020
Closed
deepakmahakale pushed a commit to deepakmahakale/botkit that referenced this issue Oct 5, 2021
@benbrown
Fixes howdyai#1920 - Use contextual adapter when spawning bots,
601ce67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbrown benbrown

Labels
None yet
Projects
None yet
Milestone
4.6.+
Development

No branches or pull requests
1 participant
@benbrown