Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis storage #37

Closed
guillaumepotier opened this issue Dec 21, 2015 · 5 comments
Closed

Redis storage #37

guillaumepotier opened this issue Dec 21, 2015 · 5 comments
Labels

Comments

@guillaumepotier
Copy link
Contributor

Hi,

I wrote a simple Redis storage using redis hashes storage to handle data. Are you interested by it? Do you want me to make a PR here and add it somewhere in the repo, or create a dedicated repo and link it in the README?

Best

@RafaelCosman
Copy link
Contributor

So far people (including me) have been submitting PRs for these, but it's not clear if that's what the managers of the repo want. If they accept our PRs today then we'll know the answer.

@benbrown
Copy link
Contributor

Yes! Please submit a pull request!! That is a great feature to have!

@guillaumepotier
Copy link
Contributor Author

Okay @benbrown, I just submitted my PR in #38, feel free to comment. I factorized my code to handle the API that do not change much bw teams, users and channels and used a code that could be simpler with more lines. If not enough readable I could develop. What I particularly like with this implementation is that very easily you could add sets, I use that to store some of my application business (tokens or sessions to be able to call my API).

@RafaelCosman
Copy link
Contributor

@guillaumepotier I left a note on your PR about passing storage_tests.js before we merge it.

@guillaumepotier
Copy link
Contributor Author

Since my second pull request have been merged, I think we could close this issue.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants