Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly trigger security session events from facebook workplace #1109 #1110

Merged
merged 2 commits into from
Jan 18, 2018

Conversation

ariel-learningpool
Copy link
Contributor

This should fix issue #1109 and properly trigger security sessions events without breaking existing functionality.

You should be able to catch events with controller:
controller.on('log_in', function(bot, message) {} );
controller.on('log_out', function(bot, message) {} );

@benbrown
Copy link
Contributor

Thanks for this PR @ariel-learningpool! I will merge it as soon as I can properly test it.

@benbrown
Copy link
Contributor

Thank you @ariel-learningpool finally merging this!

@ariel-learningpool
Copy link
Contributor Author

@benbrown that's great news. Thanks for merging

@benbrown benbrown merged commit d51f415 into howdyai:master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants