Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ws library #1154

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Upgrade ws library #1154

merged 1 commit into from
Jan 10, 2018

Conversation

Naktibalda
Copy link
Contributor

Breaking changes in 3.0.0 were:

    Removed the upgradeReq property (#1099).
    Removed unnecessary events (#1100).
    Removed the flags argument from the 'message', 'ping', and 'pong'
    events (#1101).
    The permessage-deflate extension is now disabled by default on the server
    (#1107).

Only flag argument change affects botkit, but flags argument was unused.

@Naktibalda
Copy link
Contributor Author

@benbrown I made pull request to master branch because lib/Slackbot_worker.js uses websockets.

@benbrown
Copy link
Contributor

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants