Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include user's email in profile if returned from facebook API #1193

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

iniq
Copy link
Contributor

@iniq iniq commented Dec 22, 2017

If the Facebook profile API returns the user's email address, which it does for Workplace integrations, the Botkit profile should include it.

This should have no impact on the current values and behaviour for page-associated bots.

Resolves #1192

If the Facebook profile API returns the user's email address, which it does for Workplace integrations, the Botkit profile should include it.
Copy link
Collaborator

@ouadie-lahdioui ouadie-lahdioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Good job

@benbrown benbrown merged commit 3db3993 into howdyai:master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants