Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Facebook's user profile object with locale. #1265

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Extend Facebook's user profile object with locale. #1265

merged 1 commit into from
Mar 15, 2018

Conversation

imjul1an
Copy link
Contributor

There is a missing field, namelylocale which is a part of the identity response object of bot.getMessageUser

@imjul1an
Copy link
Contributor Author

imjul1an commented Feb 24, 2018 •
edited
Loading

@benbrown @peterswimm I'm also kind of confused with the name of this function getMessageUser since I use it to getUserProfile.

@imjul1an
Copy link
Contributor Author

@benbrown @ouadie-lahdioui @peterswimm, Sorry guys for intolerance and tag all of you 😃 this is a critical issue for us, to go live upcoming Monday, and I would love to know if this fix makes sense or not or maybe there is another way to identify user's locale? Thanks in advance.

@peterswimm
Copy link
Contributor

How is making this public blocking you going live? You can always just publish to your own repro and go live against that.

I will ping our team and see if they can review, but we were not planning a release in your timeframe.

@imjul1an
Copy link
Contributor Author

imjul1an commented Feb 28, 2018 •
edited
Loading

How is making this public blocking you going live? You can always just publish to your own repro and go live against that.

@peterswimm that's what we did. Thx for reply. Looking forward to PR review.

@benbrown benbrown merged commit d2ae135 into howdyai:master Mar 15, 2018
@peterswimm
Copy link
Contributor

@julianusti The latest version has been fixed, let us know if you run into any issues.

@dependabot-preview dependabot-preview bot mentioned this pull request Mar 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbrown benbrown Awaiting requested review from benbrown

Assignees
No one assigned
Labels
enhancement Facebook-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imjul1an @peterswimm @benbrown