Send broadcast function: added missing args(notification and tag) #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmranAbazid
changed the title
ouadie-lahdioui
suggested changes
Mar 7, 2018
lib/Facebook.js
Outdated
| 'message_creative_id': message_creative | ||
| }; | ||
| } else { | ||
| body = { |
There was a problem hiding this comment.
It will be smart to clone all message_creative attributes into the body instead of copying one by one :
} else {
body = message_creative
}
|
Good point, updated the code. |
|
LGTM, Thank you 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #1271