Add receive_error event if middleware throws error #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an error occurred in the receive middleware, the message would just get swallowed and not processed. The error is just logged to console. Now an actual event is fired which can be caught in a skill.
- CoreBot.js: firing receive_error event with the error message of the middleware
- Error can be caught by using `controller.on('receive_error', function(err, bot, message){[HANDLE THE ERROR...]});`
mkilp
added a commit
to mkilp/botkit-docs
that referenced
this pull request
Jul 23, 2018
Update the core docs to explain how to handle errors in receive middlewares. Related to howdyai/botkit#1425
benbrown
approved these changes
Aug 10, 2018
|
This is merged into my next release branch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an error occurred in the receive middleware, the message would just get swallowed and not processed. The error is just logged to console. Now an actual event is fired which can be caught in a skill.
controller.on('receive_error', function(err, bot, message){[HANDLE THE ERROR...]});