Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only require simple_storage when used #1566

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

tonymet
Copy link
Contributor

@tonymet tonymet commented Jan 26, 2019

  • this benign change reduces mem usage by about 2MB when not using simple_storage

Test Results

> botkit@0.7.2 test /Users/tonym/sources/botkit
> jest

 PASS  test/Botkit.test.js
  Botkit
    ✓ Should export bot interfaces (9ms)

 PASS  test/facebook/Bot.test.js
  FacebookBot
    ✓ adds 1 + 2 to equal 3 (8ms)

 PASS  test/facebook/Handover_profile_api.test.js
  Handover_profile_api
    ✓ Should not fail (4ms)

 PASS  test/facebook/Tags_api.test.js
  Tags_api
    ✓ Should not fail (1ms)

 PASS  test/facebook/Broadcast_api.test.js
  Broadcast_api
    ✓ Should not fail (2ms)

 PASS  test/facebook/Insights_api.test.js
  Insights_api
    ✓ Should not fail (1ms)

 PASS  test/facebook/User_profile_api.test.js (6.653s)
  User_profile_api
    ✓ Should not fail (10ms)

 PASS  test/facebook/Attachment_upload_api.test.js (6.72s)
  Attachment_upload_api
    ✓ Should not fail (69ms)

 PASS  test/facebook/Personas_profile_api.test.js (6.678s)
  Personas_profile_api
    ✓ Should not fail (79ms)

 PASS  test/facebook/Messenger_profile_api.test.js (6.749s)
  Messenger_profile_api
    ✓ Should not fail (26ms)

 PASS  test/facebook/Nlp_api.test.js
  Nlp_api
    ✓ Should not fail (1ms)

Test Suites: 11 passed, 11 total
Tests:       11 passed, 11 total
Snapshots:   0 total
Time:        7.554s
Ran all test suites.

@tonymet
Copy link
Contributor Author

tonymet commented Feb 14, 2019

nice anything else needed from me here for merging?

@benbrown benbrown merged commit e36449c into howdyai:master Feb 21, 2019
@tonymet
Copy link
Contributor Author

tonymet commented Feb 21, 2019

Thanks guys for all the support. great working together 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants