Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webex adapter to support FormData #1667

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Conversation

Teamop
Copy link
Contributor

@Teamop Teamop commented May 20, 2019

  1. the webex message api also supports to send messages with attachement, at this time, the request content-type is multipart/form-data, so here the null value will break the FormData used by request.
  2. roomId, toPersonId and toPersonEmail should be provided only one, otherwise, BadRequest: Message destination could not be determined. Provide only one destination in the roomId, toPersonEmail, or toPersonId field

@msftclas
Copy link

msftclas commented May 20, 2019

CLA assistant check
All CLA requirements met.

@Teamop
Copy link
Contributor Author

Teamop commented May 22, 2019

@benbrown When it will be merged and released? Cause it blocks our development of the webex bot. Thanks

@benbrown benbrown added 4.0.3 and removed 4.0.3 labels May 24, 2019
@benbrown
Copy link
Contributor

This will be part of 4.5!

@benbrown benbrown merged commit 85835b5 into howdyai:master Jul 24, 2019
@Teamop Teamop deleted the fix-webex branch July 24, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants