New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix convo messages don't go through send middleware #1720

Closed

adantoscano wants to merge 2 commits into howdyai:master from adantoscano:fix-convo-send-middleware

Contributor

adantoscano commented Jul 10, 2019 •

edited

Related to #1701

adantoscano added 2 commits

July 10, 2019 14:42


          Run middleware in makeOutgoing


          Add missed param

c3b8901

Contributor

benbrown commented Jul 22, 2019

Good effort, but this is missing a bunch of promise handling which will cause this to break. I am going to attempt a fix like this myself.

benbrown mentioned this pull request

WIP: v4.5 #1733

Merged

benbrown closed this

adantoscano deleted the fix-convo-send-middleware branch

July 25, 2019 15:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment