Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Webex) Remove files key with empty string value #1906

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

viveksyngh
Copy link
Contributor

This commit removes sending files key with empty string value when
there are no files while sending a message. files key with empty string is causing API to fail
with below BadRequest: "Unable to retrieve content.". I have validated
that by sending request to webex api from webex developer console.

Signed-off-by: Vivek Singh vivekkmr45@yahoo.in

This commit removes sending `files` key with empty string value when
there are no files while sending a message. `files` key with empty
string is causing API to fail with below `BadRequest: "Unable to retrieve content."`.
I have validated that by sending request to webex api from webex developer console.

Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
@msftclas
Copy link

msftclas commented Feb 1, 2020

CLA assistant check
All CLA requirements met.

@viveksyngh
Copy link
Contributor Author

viveksyngh commented Feb 1, 2020

I was trying webex adapter with botbuilder and I was able to get my bot app running and getting webhook callback from webex but it was not able to send the messages. It was failing with below error.

BadRequest: Unable to retrieve content.
POST https://hydra-a.wbx2.com/v1/messages
WEBEX_TRACKING_ID: webex-js-sdk_b3d434d5-da91-48ac-bf92-99c05764affc_8

After some investigation, I found that it was sending files key with empty even though there were no files. I tried the same payload in the webex developer console and there also it failed with same error. After I removed the files with empty value, it was able to send messages.

So It will be good idea to remove this key and send only if there are files.

@viveksyngh viveksyngh changed the title Remove files key with empty string value (Webex) Remove files key with empty string value Feb 1, 2020
@benbrown
Copy link
Contributor

Included in the next release -> #1929

@benbrown benbrown mentioned this pull request Mar 11, 2020
@benbrown benbrown merged commit c9c2993 into howdyai:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants