Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Facebook "attachment" type of objects for conversat… #208

Closed
wants to merge 6 commits into from
Closed

Conversation

tkornblit
Copy link

…ions.

@tkornblit tkornblit closed this May 2, 2016
@tkornblit tkornblit reopened this May 2, 2016
@crummy
Copy link

crummy commented May 10, 2016

Works great for me, thanks - just what I was looking for.

BTW, I had to add lodash to package.json to build it.

Here's how I tested it:

  var sayRandomImage = function(convo, urls) {
    var imageUrl = urls[Math.floor(Math.random()*urls.length)];
    var msg = {
      "attachment": {
        "type": "image",
        "payload": {
          "url": imageUrl
        }
      }
    };
    convo.say(msg);
  }

@tkornblit
Copy link
Author

Cool brother. What are you working on?

Tom Kornblit

On May 10, 2016, at 1:53 PM, Malcolm Crum notifications@github.com wrote:

Works great for me, thanks - just what I was looking for.

BTW, I had to add lodash to package.json to build it.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub #208 (comment)

@crummy
Copy link

crummy commented May 10, 2016

Experimenting with an interactive resume bot for my girlfriend. Images were a must :)

@crummy
Copy link

crummy commented May 10, 2016

One thing I noticed is that image messages sometimes arrive out of order with text messages. Not sure why, perhaps that's a facebook issue. I'm considering increasing the delay between messages to help.

@tkornblit
Copy link
Author

Use botkits Conversation class. It has a built-in queue mechanism.

Tom Kornblit

On May 10, 2016, at 3:32 PM, Malcolm Crum notifications@github.com wrote:

One thing I noticed is that image messages sometimes arrive out of order with text messages. Not sure why, perhaps that's a facebook issue. I'm considering increasing the delay between messages to help.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub #208 (comment)

@benbrown
Copy link
Contributor

@tkornblit thanks for the PR. I'm merging in the attachment related features here, but not sure about the changes you've made to the findConvo and others. Maybe open a new PR if you want to get that stuff included?

@benbrown benbrown closed this May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants