Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook POST message using JSON and newer endpoint to support Emojis. #317

Merged
merged 5 commits into from
Aug 13, 2016
Merged

Facebook POST message using JSON and newer endpoint to support Emojis. #317

merged 5 commits into from
Aug 13, 2016

Conversation

tkornblit
Copy link

The older Facebook endpoint doesn't support (All) Emojis. Using JSON and the new endpoint theres now support :).

@krismuniz
Copy link
Contributor

So, now you can specify the access_token in the body of the request instead of a query string in the url?

@tkornblit
Copy link
Author

I think the problem was more in the Form be JSON way of posting to Facebook, and potentially with the endpoint version itself.

The access token can be in the URL or body. Doesn't matter.

Sent from my iPhone

On Jul 11, 2016, at 12:24 PM, Kristian Muñiz notifications@github.com wrote:

So, now you can specify the access_token in the body of the request instead of a query string in the url?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dcsan
Copy link

dcsan commented Jul 12, 2016

hey, even with the old version (current botkit) how are you sending emoji to facebook?
are you using some type of pseudo codes? or just the basic ascii smiley emoji FB will convert ( 3> etc)

@tkornblit
Copy link
Author

Using the new update you can send them with plaintext. No pseudo code required.

Sent from my iPhone

On Jul 11, 2016, at 8:03 PM, dc notifications@github.com wrote:

hey, even with the old version (current botkit) how are you sending emoji to facebook?
are you using some type of pseudo codes? or just the basic emoji FB will convert ( 3> etc)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dcsan
Copy link

dcsan commented Jul 12, 2016 via email

@tkornblit
Copy link
Author

Not sure I understand the question

Sent from my iPhone

On Jul 11, 2016, at 8:17 PM, dc notifications@github.com wrote:

right, but waiting for that to get merged...​ meantime wanted to know what
pseudo code methods there are.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dcsan
Copy link

dcsan commented Jul 12, 2016

until your PR is merged - how do you send emoji to FBM?

@tkornblit
Copy link
Author

tkornblit commented Jul 12, 2016

you can't.

Sent from my iPhone

On Jul 11, 2016, at 8:39 PM, dc notifications@github.com wrote:

until your PR is merged - how do you send emoji to FBM?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

…times process messages out of order when using images due to the file size processing time. 1500 seconds seems to fix it.
@@ -823,7 +823,7 @@ function Botkit(configuration) {
// set up a once a second tick to process messages
botkit.tickInterval = setInterval(function() {
botkit.tick();
}, 1000);
}, 1500);
Copy link
Contributor

@anonrig anonrig Jul 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason to change the interval to 1500 ms?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out you can revert this as I don’t think it makes a difference. Basically the issue with the framework with Facebook is that if you send 2 or 3 messages, and one of them is an image for some reason it will come out of order. It’s something with facebooks queue on the backend. So i think what needs to happen is to wait in between messages before sending

Tom Kornblit

On Jul 17, 2016, at 8:44 PM, Yagiz Nizipli notifications@github.com wrote:

In lib/CoreBot.js #317 (comment):

@@ -823,7 +823,7 @@ function Botkit(configuration) {
// set up a once a second tick to process messages
botkit.tickInterval = setInterval(function() {
botkit.tick();

  •        }, 1000);
    
  •        }, 1500);
    
    Is there a particular reason to change the setInterval method to 1500 ms?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/howdyai/botkit/pull/317/files/809cf5d21ca7ca7ba5f4168cda8fb58ec0eb723c#r71093302, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7b-SlWA9071Oinid5i1DBWlSJPN4ZDks5qWsxvgaJpZM4JI56v.

@dcsan
Copy link

dcsan commented Aug 5, 2016

this is a month old, would be nice to get merged in, a lot of chatter in #fb-messenger about emoji.

@tkornblit
Copy link
Author

What do you need from me to get this merged?

Sent from my iPhone

On Aug 5, 2016, at 6:03 AM, dc notifications@github.com wrote:

this is a month old, would be nice to get merged in, a lot of chatter in #fb-messenger about emoji.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@benbrown
Copy link
Contributor

So sorry for the delay! Merging. Thank you for this fix.

@benbrown benbrown closed this Aug 13, 2016
@benbrown benbrown reopened this Aug 13, 2016
@benbrown benbrown merged commit 594a0bb into howdyai:master Aug 13, 2016
@tkornblit
Copy link
Author

Awesome. This actually comes at an interesting time. I wanted to run something by you and see what you thought.

The past 4 months I’ve been working on building my own framework that wraps botkit. It essentially exposes a Data Description JSON Language that enables you to write bots using just data.

I think this will be really helpful for other developers, so I’m open-sourcing it, in hopes that it helps developers build more rapidly and cross platform.

I call the project Mermaid https://github.com/sage-bots/mermaid, and would love to hear your thoughts.

-Tom

Tom Kornblit
Founder of Sage http://www.sagebots.com/
Personal Blog http://blog.tomkornblit.com/ | LinkedIn https://www.linkedin.com/in/tomkornblit | Twitter https://twitter.com/tkornblit

On Aug 12, 2016, at 9:56 PM, Ben Brown notifications@github.com wrote:

Merged #317 #317.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #317 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AB7b-Wo4Ra8_WwZ_dT3bF-bXmQIQBpv6ks5qfSRJgaJpZM4JI56v.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants