Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync Makefile with other repositories #14

Merged
merged 7 commits into from
Apr 16, 2021
Merged

sync Makefile with other repositories #14

merged 7 commits into from
Apr 16, 2021

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Mar 30, 2021

Fixes #18 and GitHub repo address in some places.

@ocaisa
Copy link
Member Author

ocaisa commented Mar 30, 2021

Hmm, this doesn't work. I tried to force updating kramdown but instead we need to wait for github-pages to be updated
This comment is no longer relevant

@ocaisa
Copy link
Member Author

ocaisa commented Apr 1, 2021

Ok, this is passing now, I've also taken the opportunity to

  • Move the --incremental flag to the configuration file (see docs for ref.), that way if it is not supported by the Jekyll being used, it won't error out
  • When we moved the repo, there were some leftover places where we were still linking to the old repo name.

@ocaisa ocaisa changed the title Address the vulnerability warning sync Makefile with other repositories Apr 7, 2021
Copy link
Member

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tkphd tkphd merged commit 75cb9cc into main Apr 16, 2021
@ocaisa ocaisa deleted the security_update branch April 20, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync Makefile with other repositories
2 participants