Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Run images by name #1505

Merged
merged 68 commits into from
Jan 6, 2023
Merged

Run images by name #1505

merged 68 commits into from
Jan 6, 2023

Conversation

lucaudill
Copy link
Collaborator

@lucaudill lucaudill commented Dec 7, 2022 •
edited
Loading

closes #1058

Here's the tea: we've noticed that some users (a.k.a. me) try to run images out of the storage directory, e.g.

$ ch-run $CH_IMAGE_STORAGE/img/foo -- echo foo

In general we don't want people to do this, so this PR is gonna make it so ch-run yells at you if you try it. Instead, we'll allow users to run images directly from storage by calling them by name, e.g.

$ ch-run foo -- echo foo

@lucaudill
initial commit [no ci]
0ee739c
@lucaudill
argument for name_to_path now pointer to char
45ddf1f
@lucaudill
new functions in ch_misc.c [no ci]
d49265a
@lucaudill
more helper functions [no ci]
a67efb5
@lucaudill
still ironing out the helper functions... [no ci]
1b1d6c2
@lucaudill
more changes [skip ci]
8c8808c
@lucaudill
yolo [skip ci]
ba91e4c
@lucaudill
give helper function more accurate name [skip ci]
5f899f1
@lucaudill
new error message [skip ci]
3613b35
@lucaudill
separate img_path and img_ref [skip ci]
66d6649
@lucaudill
new environment variable doesn't work in test suite 🙃
692e2ac
@lucaudill
let's see what breaks
fb871ae
@lucaudill
remove error message
f085e37
@lucaudill
why can't we chdir into newroot?
a9faa9b
@lucaudill
debugging [skip ci]
4d730ad
@lucaudill
more random debugging [skip ci]
07414a5
@lucaudill
fix one random bug [skip ci]
e988852
@lucaudill
run ci pls
9b39248
@lucaudill
any new insights from ci?
b62066f
@lucaudill
debugging again [skip ci]
394fa37
@lucaudill
fixed a bug
73cbd17
@lucaudill
remove a bunch of debug messages [skip ci]
8f21672
@lucaudill
run ci without debug messages
4a54480
@lucaudill
nolo
e73095d
@lucaudill
change yolo to unsafe, add --storage flag
b808eb9
@lucaudill
get rid of yolo for real
7630831
@lucaudill
some cleanup
fb0da42
@lucaudill
new bats tests
901ae6c
@lucaudill
cleanup
b41d804
@lucaudill
appease shellcheck or whatever
b0e857d
@reidpr reidpr marked this pull request as ready for review December 22, 2022 22:37
reidpr
reidpr reviewed Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! See tidy (untested). LMK what questions you have. Hope your holiday is going well.

test/run/ch-run_misc.bats Outdated Show resolved Hide resolved
test/run/ch-run_misc.bats Outdated Show resolved Hide resolved
@lucaudill lucaudill requested a review from reidpr January 5, 2023 20:09
reidpr
reidpr approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Please check my tidy. If it looks good and tests pass, I'll merge.

@lucaudill lucaudill requested a review from reidpr January 6, 2023 01:04
@reidpr reidpr merged commit 0e9fcd9 into master Jan 6, 2023
@reidpr reidpr deleted the run-by-name-1058 branch January 6, 2023 16:51
@nschan nschan mentioned this pull request Oct 31, 2023
Open
@reidpr reidpr mentioned this pull request Nov 7, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reidpr reidpr Awaiting requested review from reidpr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ch-run: run images by name
2 participants
@lucaudill @reidpr