Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: correct nvidia configure check to use NVIDIA_CLI consistently #855

Merged
merged 1 commit into from Sep 22, 2020

Conversation

heasterday
Copy link
Contributor

Addresses #853

Thank you to @jyaghob for the report and the suggested fix.

Tested on an platform with nvidia libraries, diff of before and after the fix below:

diff before.txt after.txt 
46c46
< checking for nVidia libraries & executables... no
---
> checking for nVidia libraries & executables... yes
72d71
< config.status: bin/config.h is unchanged
158c157
<   inject nVidia GPU libraries: no
---
>   inject nVidia GPU libraries: yes
160c159
<     nVidia libraries & executables present ... no
---
>     nVidia libraries & executables present ... yes

@heasterday
Copy link
Contributor Author

@jyaghob Whenever you have a minute could you verify this fix resolves the issue you are seeing?

@heasterday heasterday changed the title Correct nvidia configure check to use NVIDIA_CLI consistently configure: correct nvidia configure check to use NVIDIA_CLI consistently Sep 22, 2020
Copy link

@jyaghob jyaghob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks. It looks fine for me.

@reidpr reidpr merged commit 38fa937 into master Sep 22, 2020
@reidpr reidpr deleted the fix-nvidia-configure-853 branch September 22, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants