Freeing sync lists #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsikich
commented
Jun 15, 2017
dsikich
commented
- I updated this to check for NULL in dcmp_strmap_compare before freeing the lists when sync is not being used.
- I took out the -o option in the dcmp man pages since it doesn't seem to be working or we don't know how to use it
- ran pandoc on markdown pages for tools
added 2 commits
June 15, 2017 15:17
adammoody
reviewed
Jun 15, 2017
src/dcmp/dcmp.c
Outdated
| mfu_flist dst_remove_list = MFU_FLIST_NULL; | ||
| mfu_flist src_cp_list = MFU_FLIST_NULL; | ||
| mfu_flist dst_remove_list = NULL; | ||
| mfu_flist src_cp_list = NULL; |
There was a problem hiding this comment.
Let's keep with setting these to MFU_FLIST_NULL, but check for that instead of NULL in the if/free blocks below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.