Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added format key to results_parse yc. #651

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

dmageeLANL
Copy link
Collaborator

On the same level as 'action'. This avoids printing results with an absurd number of digits to the terminal. And facilitates displaying results as the user desires.

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

Am I supposed to fill that out?

Anyway, I'm missing the documentation to the docs and typed function arguments. I'll fill those in, but now I want to see if it works. This feature adds a 'format' key to a result which will store and display the result as the user intends. It's inspired by this:

Ugly_pav_output

Which is ugly and doesn't match the format I'm visually comparing the results to, which is annoying.

dmageeLANL and others added 5 commits May 26, 2023 18:12
On the same level as 'action'.  This avoids printing results with an absurd number of digits to the terminal. And facilitates displaying results as the user desires.
… script which does this in test/utils. It's a standalone executable which only acts on .py files and takes a space separated list of directories to recursively cleanse of trailing whitespace. If no argument is given it acts on the directory that contains the script file. Put it in your PATH and enjoy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant