Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent treatment of base class methods #32

Closed
tskisner opened this issue May 3, 2016 · 1 comment
Closed

Consistent treatment of base class methods #32

tskisner opened this issue May 3, 2016 · 1 comment
Assignees
@tskisner
Labels
enhancement

Comments

@tskisner
Copy link
Member

tskisner commented May 3, 2016

The TOD base class is currently acting as both an interface definition for internal methods called by the high-level read/write functions and as a memory-backed generic TOD container. We should split this functionality into the actual base class where the internal methods (prefixed with underscore) raise exceptions when called and a separate derived class which has a memory-based backend.
@tskisner tskisner self-assigned this May 3, 2016
tskisner added a commit that referenced this issue May 3, 2016
@tskisner
Refactor TOD base class to not provide implementations for internal m…
3279ef6 
…ethods. Split that functionality out into a TODCache class. Also add position and velocity methods to the TOD API. Closes #28 and #32.
@tskisner tskisner mentioned this issue May 3, 2016
Merged
@tskisner
Copy link
Member Author

tskisner commented May 6, 2016

This was implemented and closed by 3279ef6.

@tskisner tskisner closed this as completed May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tskisner tskisner

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tskisner