Consolodate creation of MPI communicators #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All split communicators are stored within the toast.Comm class, including the world, group, rank, node, world node-rank, group node-rank, and a store of row / column communicators that are created as needed for different values of process_rows. * These communicators are re-used within each observation, including passing the node and group node-rank communicators to the pshmem.MPIShared constructor. * Overall cleanup across the code of the use of these communicators.
…cators for every row and column communicator.
keskitalo
reviewed
Oct 5, 2021
keskitalo
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All split communicators are stored within the toast.Comm class,
including the world, group, rank, node, world node-rank, group
node-rank, and a store of row / column communicators that are
created as needed for different values of process_rows.
These communicators are re-used within each observation, including
passing the node and group node-rank communicators to the
pshmem.MPIShared constructor.
Overall cleanup across the code of the use of these communicators.