Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new mapmaking template for periodic signals #690

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

tskisner
Copy link
Member

This adds a new template that regresses components of detector data that are correlated with a shared data field whose values are periodic (HWP angle, Azimuth, etc). The values of the periodic field are binned and a
different set of template amplitudes are solved for each detector and each observation. Additional changes:

  • Unit test for fake HWPSS removal in satellite and ground simulations.

  • Unit test helper for healpix map plotting, similar to the helper function for WCS plotting.

  • Added functions to the Offset template to support writing and plotting solved amplitudes.

  • Small improvement to noise model fitting.

  • Run format_source.sh

Below are some plots from the unit tests, showing the removal of fake HWPSS in the template-cleaned timestream prior to final binning.
satellite_hwp-compare_test_000005_2023-02-23T00:50+00:00_1677113400_D0A-150_500.pdf
satellite_hwp-compare_test_000005_2023-02-23T00:50+00:00_1677113400_D0A-150_6000.pdf

This adds a new template that regresses components of
detector data that are correlated with a shared data
field whose values are periodic (HWP angle, Azimuth, etc).
The values of the periodic field are binned and a
different set of template amplitudes are solved for
each detector and each observation.  Additional changes:

* Unit test for fake HWPSS removal in satellite and
  ground simulations.

* Unit test helper for healpix map plotting, similar
  to the helper function for WCS plotting.

* Added functions to the Offset template to support
  writing and plotting solved amplitudes.

* Small improvement to noise model fitting.

* Run format_source.sh
Copy link
Member

@keskitalo keskitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! No suggestions.

src/toast/tests/_helpers.py Show resolved Hide resolved
@tskisner tskisner merged commit 7615cfd into hpc4cmb:toast3 Aug 16, 2023
6 checks passed
@tskisner tskisner deleted the periodic branch August 16, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants