[fx] Modify solver linearize and add corresponding test #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ColossalAI
Daily merge
added 2 commits
September 1, 2022 15:57
…ossalAI into hotfix/fix_solver_linearize
|
|
super-dainiu
reviewed
Sep 1, 2022
FrankLeeeee
reviewed
Sep 1, 2022
super-dainiu
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New
In PR #1496, @super-dainiu suggests that we could use more elegant linearize code and node structure, but at that time we still worried about the time overhead for solver to solve the sequence. After some experiments, I'm sure that this old linearize could be left and use the suggested structure. I also add a test to check if the solver's sequence and annotated result is correct. Lastly, I fix a couple of lines of old inefficient code in
activation_checkpoint_codgen.pyandckpt_solver_rotor.py.