Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chatgpt]fix lora bug #2974

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[chatgpt]fix lora bug #2974

merged 2 commits into from
Mar 2, 2023

Conversation

ht-zhou
Copy link
Contributor

@ht-zhou ht-zhou commented Mar 2, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234
fixed #2877

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.
fix lora bug
change the name 'body' back to 'model' to ensure the critic can be initialize from RM
change epoch default to 1

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ht-zhou ht-zhou added bug Something isn't working chatgpt ChatGPT Application labels Mar 2, 2023
@ht-zhou ht-zhou requested a review from Fazziekey March 2, 2023 09:47
@Fazziekey Fazziekey merged commit c9e27f0 into hpcaitech:main Mar 2, 2023
@ht-zhou ht-zhou linked an issue Mar 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chatgpt ChatGPT Application
Projects
None yet
2 participants