Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Add opencontainers image-spec to Dockerfile #3006

Merged
merged 3 commits into from
Mar 14, 2023
Merged

[docker] Add opencontainers image-spec to Dockerfile #3006

merged 3 commits into from
Mar 14, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Fixes #3005

📝 What does this PR do?

This PR makes few changes to improve the overall quality of the docker image 🐳 . For reference more annotations can be found here

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes hell yeah, I do.

This PR makes few changes to improve the overall quality of the docker image 🐳 . For reference more annotations can be found [here](https://github.com/opencontainers/image-spec/blob/main/annotations.md)
docker/Dockerfile Outdated Show resolved Hide resolved
@FrankLeeeee FrankLeeeee merged commit 1a46e71 into hpcaitech:main Mar 14, 2023
@SauravMaheshkar SauravMaheshkar deleted the docker-image-spec branch March 14, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL]: add image specifications to Dockerfile
2 participants