Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[booster] init module structure and definition #3056

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

FrankLeeeee
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3050

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR initialized the booster module with respect to #3046 . Some actions taken include:

  1. migrate the class definition from the discussion to the Python files
  2. added typing hinting for all methods
  3. added #TODO annotation for methods to be implemented
  4. added __all__ for namescoping

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee self-assigned this Mar 8, 2023
@FrankLeeeee FrankLeeeee added the API related to API changes label Mar 8, 2023
@FrankLeeeee FrankLeeeee merged commit f19b49e into hpcaitech:main Mar 9, 2023
@FrankLeeeee FrankLeeeee deleted the feature/booster-init branch March 9, 2023 03:27
Fazziekey pushed a commit to Fazziekey/ColossalAI that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API related to API changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[booster] set up the booster module structure and class definition
2 participants