Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chat] ChatGPT train prompts on ray example #3309

Merged
merged 15 commits into from
Apr 13, 2023

Conversation

MisterLin1995
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234
closed #3291

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@MisterLin1995 MisterLin1995 changed the title ChatGPT train prompts on ray example [WIP] ChatGPT train prompts on ray example Mar 29, 2023
Copy link

@SongGuyang SongGuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I has some suggestions:

  • Do we need an independent directory for the code about ray integration? E.g. applications/Chat/experimental/ray/
  • We can use ray.wait instead of ray.get when we should wait a lot object refs. In this way, you can set wait timeout and it is easy to debug. (We can also optimize this in the following works, don't block current PR)
  • We can add a design doc or design graph to explain the architecture.(don't block current PR)

@MisterLin1995 MisterLin1995 changed the title [WIP] ChatGPT train prompts on ray example ChatGPT train prompts on ray example Apr 4, 2023
@ver217
Copy link
Member

ver217 commented Apr 13, 2023

Can you move your files to Chat/examples/community/ray first? And you can update the README.

@ver217 ver217 changed the title ChatGPT train prompts on ray example [chat] ChatGPT train prompts on ray example Apr 13, 2023
@ver217 ver217 added the chatgpt ChatGPT Application label Apr 13, 2023
@ver217 ver217 merged commit 1a809ed into hpcaitech:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chatgpt ChatGPT Application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: ChatGPT example on Ray
3 participants