-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chat] ChatGPT train prompts on ray example #3309
Merged
ver217
merged 15 commits into
hpcaitech:main
from
MisterLin1995:marcus-chatgpt-ray-example
Apr 13, 2023
Merged
[chat] ChatGPT train prompts on ray example #3309
ver217
merged 15 commits into
hpcaitech:main
from
MisterLin1995:marcus-chatgpt-ray-example
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterLin1995
changed the title
ChatGPT train prompts on ray example
[WIP] ChatGPT train prompts on ray example
Mar 29, 2023
SongGuyang
reviewed
Mar 31, 2023
SongGuyang
reviewed
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I has some suggestions:
- Do we need an independent directory for the code about ray integration? E.g.
applications/Chat/experimental/ray/
- We can use ray.wait instead of ray.get when we should wait a lot object refs. In this way, you can set wait timeout and it is easy to debug. (We can also optimize this in the following works, don't block current PR)
- We can add a design doc or design graph to explain the architecture.(don't block current PR)
applications/Chat/examples/train_prompts_on_ray_job_submission_script.py
Outdated
Show resolved
Hide resolved
applications/Chat/examples/train_prompts_on_ray_job_submission_script.py
Outdated
Show resolved
Hide resolved
MisterLin1995
changed the title
[WIP] ChatGPT train prompts on ray example
ChatGPT train prompts on ray example
Apr 4, 2023
Can you move your files to |
ver217
changed the title
ChatGPT train prompts on ray example
[chat] ChatGPT train prompts on ray example
Apr 13, 2023
ver217
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description
🚨 Issue number
📝 What does this PR do?
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.