HPCC-16813 Fix various gcc warnings

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
hpcc-systems · Jan 4, 2017 · a1b4886 · a1b4886
1 parent 3c7ecb4
commit a1b4886
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 16 deletions.
diff --git a/common/thorhelper/layouttrans.cpp b/common/thorhelper/layouttrans.cpp
@@ -794,7 +794,7 @@ class RecordLayoutTranslatorTest : public CppUnit::TestFixture
             Owned<ITypeInfo> type;
             IAtom * name;
             size32_t size;
-            unsigned keyed;
+            unsigned keyed = 0;
             unsigned f;
             for(f = 0; getFieldData(m, f, type, name, size, keyed); ++f)
             {

diff --git a/deployment/deploy/DeployTask.cpp b/deployment/deploy/DeployTask.cpp
@@ -1089,8 +1089,8 @@ class CDeployTask : public CInterface, implements IDeployTask
       Owned<IFile> pDstFile = createIFile(target);
       CDateTime dtSrc;
       CDateTime dtDst;
-      offset_t  szSrc;
-      offset_t  szDst;
+      offset_t  szSrc = 0;
+      offset_t  szDst = 0;
 
       if (!getFileAttributes(pSrcFile, dtSrc, szSrc, mode) ||
           !getFileAttributes(pDstFile, dtDst, szDst, mode))

diff --git a/esp/bindings/SOAP/Platform/soapmessage.cpp b/esp/bindings/SOAP/Platform/soapmessage.cpp
@@ -326,7 +326,7 @@ IRpcMessage* createRpcMessage(const char* rootTag, StringBuffer& xml)
 {
     CRpcMessage* rpc = new  CRpcMessage(rootTag);
 
-    auto_ptr<XmlPullParser> xpp(new XmlPullParser(xml.str(), xml.length()));
+    std::unique_ptr<XmlPullParser> xpp(new XmlPullParser(xml.str(), xml.length()));
     xpp->setSupportNamespaces(true);
 
     rpc->unmarshall(xpp.get());

diff --git a/esp/bindings/SOAP/client/soapclient.cpp b/esp/bindings/SOAP/client/soapclient.cpp
@@ -237,7 +237,7 @@ int CSoapClient::postRequest(const char* contenttype, const char* soapaction, IR
         return rt;
 
 //  DBGLOG("response SoapClient got from soap server = \n%s", responsebuf.str());
-    auto_ptr<XmlPullParser> xpp(new XmlPullParser());
+    std::unique_ptr<XmlPullParser> xpp(new XmlPullParser());
     int bufSize = responsebuf.length();
     xpp->setSupportNamespaces(true);
     xpp->setInput(responsebuf.str(), bufSize);

diff --git a/esp/esdllib/esdl_def.cpp b/esp/esdllib/esdl_def.cpp
@@ -1838,7 +1838,7 @@ class EsdlDefLoader : public CInterface
 
         if (xmlDef.length())
         {
-            auto_ptr<XmlPullParser> xpp(new XmlPullParser());
+            std::unique_ptr<XmlPullParser> xpp(new XmlPullParser());
 
             int bufSize = xmlDef.length();
             xpp->setSupportNamespaces(true);

diff --git a/esp/esdllib/esdl_transformer2.cpp b/esp/esdllib/esdl_transformer2.cpp
@@ -1781,7 +1781,7 @@ static const char * gotoNextHPCCDataset(XmlPullParser &xppx, StartTag &stag)
 
 void Esdl2Transformer::processHPCCResult(IEspContext &ctx, IEsdlDefMethod &mthdef, const char *xml, IXmlWriterExt* writer, StringBuffer &logdata, unsigned int flags, const char *ns, const char *schema_location)
 {
-    auto_ptr<XmlPullParser> xpp(new XmlPullParser());
+    std::unique_ptr<XmlPullParser> xpp(new XmlPullParser());
 
     xpp->setSupportNamespaces(true);
     xpp->setInput(xml, strlen(xml));

diff --git a/esp/platform/tokenserialization.hpp b/esp/platform/tokenserialization.hpp
@@ -159,6 +159,7 @@ class TokenDeserializer
         skipWhitespace(ptr);
         if (!*ptr)
         {
+            value = false;
             result = Deserialization_INVALID_TOKEN;
         }
         else

diff --git a/plugins/couchbase/couchbaseembed.cpp b/plugins/couchbase/couchbaseembed.cpp
@@ -492,7 +492,7 @@ namespace couchbaseembed
 
     double CouchbaseEmbedFunctionContext::getRealResult()
     {
-        double mydouble;
+        double mydouble = 0.0;
         auto value = nextResultScalar();
         handleDeserializeOutcome(m_tokenDeserializer.deserialize(value, mydouble), "real", value);
 
@@ -501,7 +501,7 @@ namespace couchbaseembed
 
     __int64 CouchbaseEmbedFunctionContext::getSignedResult()
     {
-        __int64 myint64;
+        __int64 myint64 = 0;
         auto value = nextResultScalar();
         handleDeserializeOutcome(m_tokenDeserializer.deserialize(value, myint64), "signed", value);
 
@@ -510,7 +510,7 @@ namespace couchbaseembed
 
     unsigned __int64 CouchbaseEmbedFunctionContext::getUnsignedResult()
     {
-        unsigned __int64 myuint64;
+        unsigned __int64 myuint64 = 0;
         auto value = nextResultScalar();
         handleDeserializeOutcome(m_tokenDeserializer.deserialize(value, myuint64), "unsigned", value);
 
@@ -806,7 +806,7 @@ namespace couchbaseembed
             return p.doubleResult;
         }
 
-        double mydouble;
+        double mydouble = 0.0;
         couchbaseembed::handleDeserializeOutcome(m_tokenDeserializer.deserialize(value, mydouble), "real", value);
         return mydouble;
     }
@@ -820,7 +820,7 @@ namespace couchbaseembed
             return p.uintResult;
         }
 
-        __int64 myint64;
+        __int64 myint64 = 0;
         couchbaseembed::handleDeserializeOutcome(m_tokenDeserializer.deserialize(value, myint64), "signed", value);
         return myint64;
     }
@@ -834,14 +834,14 @@ namespace couchbaseembed
             return p.uintResult;
         }
 
-        unsigned __int64 myuint64;
+        unsigned __int64 myuint64 = 0;
         couchbaseembed::handleDeserializeOutcome(m_tokenDeserializer.deserialize(value, myuint64), "unsigned", value);
         return myuint64;
     }
 
     void CouchbaseRowBuilder::getStringResult(const RtlFieldInfo *field, size32_t &chars, char * &result)
     {
-         const char * value = nextField(field);
+        const char * value = nextField(field);
 
         if (!value || !*value)
         {

diff --git a/system/security/LdapSecurity/ldapconnection.cpp b/system/security/LdapSecurity/ldapconnection.cpp
@@ -329,7 +329,7 @@ class CLdapConfig : implements ILdapConfig, public CInterface
         else
             m_ldap_secure_port = atoi(portbuf.str());
 
-        int rc;
+        int rc = LDAP_OTHER;
         StringBuffer hostbuf, dcbuf;
         const char * ldapDomain = cfg->queryProp(".//@ldapDomain");
         for (int numHosts=0; numHosts < getHostCount(); numHosts++)

diff --git a/testing/unittests/jlibtests.cpp b/testing/unittests/jlibtests.cpp
@@ -124,7 +124,7 @@ class JlibSemTestStress : public CppUnit::TestFixture
         sem.signal();
         if (!sem.wait(1000))
         {
-            VStringBuffer errMsg("Semaphore stalled (%s:%s)", sanitizeSourceFile(__FILE__), __LINE__);
+            VStringBuffer errMsg("Semaphore stalled (%s:%d)", sanitizeSourceFile(__FILE__), __LINE__);
             CPPUNIT_FAIL(errMsg.str());
         }
         testTimedElapsed(sem, 5, 1000);