HPCC-18627 Fix issue with subscription notify and changes at '/'

Root level changes were not triggering subscription notifications Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
hpcc-systems · Oct 27, 2017 · b6f0a3c · b6f0a3c
1 parent b6a0769
commit b6f0a3c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/dali/base/dasds.cpp b/dali/base/dasds.cpp
@@ -689,6 +689,11 @@ class CSubscriberContainer : public CSubscriberContainerBase
         const MemoryAttr &ma = subscriber->queryData();
         MemoryBuffer mb(ma.length(), ma.get());
         mb.read(xpath);
+        if (xpath.length() && ('/' != xpath.get()[xpath.length()-1]))
+        {
+            StringBuffer _xpath(xpath);
+            xpath.set(_xpath.append('/'));
+        }
         mb.read(sub);
         if (mb.remaining()) // remaining
             mb.read(sendValue);
@@ -8313,7 +8318,7 @@ class CSubscriberNotifyScanner : public CInterface
             {
                 if ('\0' == *head)
                     return subCommitExact; // absolute match
-                else if (!wild && '/' != *head) // e.g. change=/a/bc, subscriber=/a/b
+                else if (!wild && '/' != *(head-1)) // e.g. change=/a/bc, subscriber=/a/b
                     return subCommitNone;
                 return subCommitBelow; // e.g. change=/a/b/c, subscriber=/a/b
             }
@@ -8431,7 +8436,7 @@ class CSubscriberNotifyScanner : public CInterface
                         CBranchChange &childChange = changes.children.item(c);
                         PushPop pp(stack, *childChange.tree);
                         size32_t parentLength = xpath.length();
-                        xpath.append('/').append(childChange.tree->queryName());
+                        xpath.append(childChange.tree->queryName()).append('/');
                         CSubscriberArray _pruned;
                         scanAll(state, childChange, stack, _pruned);
                         ForEachItemIn(i, _pruned) subs.append(*LINK(&_pruned.item(i)));
@@ -8502,7 +8507,7 @@ class CSubscriberNotifyScanner : public CInterface
         {
             CBranchChange &childChanges = changes.children.item(c);
             size32_t parentLength = xpath.length();
-            xpath.append('/').append(childChanges.tree->queryName());
+            xpath.append(childChanges.tree->queryName()).append('/');
             CSubscriberArray pruned;
             scan(childChanges, stack, pruned);
             ForEachItemIn(i, pruned) subs.append(*LINK(&pruned.item(i)));

diff --git a/dali/base/dasds.ipp b/dali/base/dasds.ipp
@@ -206,10 +206,9 @@ public:
             unsigned i = 1;
             for (;;)
             {
-                str.append(item(i).queryName());
+                str.append(item(i).queryName()).append('/');
                 if (++i >= ordinality())
                     break;
-                str.append('/');
             }
         }
         return str;