HPCC-20138 Unprotected variable causing esp core

- Remove the unprotected (and unused) variable and related set/get methods Signed-off-by: mayx <yanrui.ma@lexisnexisrisk.com>
hpcc-systems · Jul 23, 2018 · b81bb60 · b81bb60
1 parent 9187aef
commit b81bb60
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/esp/bindings/SOAP/Platform/soapbind.cpp b/esp/bindings/SOAP/Platform/soapbind.cpp
@@ -213,10 +213,6 @@ int CHttpSoapBinding::HandleSoapRequest(CHttpRequest* request, CHttpResponse* re
         soapresponse->setHttpResp(response);
     }
 
-    StringBuffer reqPath;
-    request->getPath(reqPath);
-    setRequestPath(reqPath.str());
-
     soapservice->processRequest(*soaprequest.get(), *soapresponse.get());
 
     //For JSON the response would have been sent except for certain errors, which will be thrown below

diff --git a/esp/bindings/http/platform/httpbinding.cpp b/esp/bindings/http/platform/httpbinding.cpp
@@ -581,13 +581,6 @@ bool EspHttpBinding::hasSubService(IEspContext &context, const char *name)
     return false;
 }
 
-
-void EspHttpBinding::setRequestPath(const char *path)
-{
-    m_reqPath.clear();
-    m_reqPath.append(path);
-}
-
 bool EspHttpBinding::rootAuthRequired()
 {
     if(!m_authmap.get())

diff --git a/esp/bindings/http/platform/httpbinding.hpp b/esp/bindings/http/platform/httpbinding.hpp
@@ -132,7 +132,6 @@ class esp_http_decl EspHttpBinding :
 
     StringAttr              m_authtype;
     StringAttr              m_authmethod;
-    StringBuffer            m_reqPath;
     StringBuffer            m_filespath;
     StringBuffer            m_wsdlAddress;
     Owned<ISecManager>      m_secmgr;
@@ -200,7 +199,6 @@ class esp_http_decl EspHttpBinding :
     const char *getWsdlAddress(){return m_wsdlAddress.str();}
     void setWsdlAddress(const char *wsdladdress){m_wsdlAddress.set(wsdladdress);}
 
-    virtual void setRequestPath(const char *path);
     virtual bool rootAuthRequired();
     virtual bool authRequired(CHttpRequest *request);
     virtual bool doAuth(IEspContext* ctx);
@@ -211,7 +209,6 @@ class esp_http_decl EspHttpBinding :
     virtual StringBuffer &generateNamespace(IEspContext &context, CHttpRequest* request, const char *serv, const char *method, StringBuffer &ns);
     virtual void getSchemaLocation(IEspContext &context, CHttpRequest* request, StringBuffer &schemaLocation );
 
-    virtual StringBuffer &getRequestPath(){return m_reqPath;}
     static int formatHtmlResultSet(IEspContext &context, const char *serv, const char *method, const char *resultsXml, StringBuffer &html);
     int formatResultsPage(IEspContext &context, const char *serv, const char *method, StringBuffer &results, StringBuffer &page);